Feat: Promote session.topDirectory and session.rootDirectory - #11779
Merged
cstamas merged 4 commits intoApr 8, 2026
Conversation
To real properies usable in POM as well, not only in config interpolation.
This comment was marked as outdated.
This comment was marked as outdated.
Comment on lines
+166
to
+170
| /** | ||
| * Returns top directory if discovered or {@code null}. | ||
| * | ||
| * @since 3.10.0 | ||
| */ |
Member
There was a problem hiding this comment.
more clear documentation will be appreciated what is difference between top and root directory
jglick
reviewed
Apr 8, 2026
|
|
||
| /** | ||
| * Returns top directory if discovered or {@code null}. | ||
| * Top directory is directory where top level POM resides with respect of any reactor limiting or shaping like use |
Contributor
There was a problem hiding this comment.
How is “top-level POM” defined exactly? It is possible for a pom-packaging module to have <module>s whose <parent> is something else. Or for modules to not be subdirectories.
Member
Author
There was a problem hiding this comment.
Top level directory is the directory where very first POM being loaded up exists. It is usually $CWD, but may be something different, ie. if you use mvn -f subproject or mvn -f module/pom.xml etc.
This was referenced Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To real properties usable in POM as well, not only in config interpolation.